make the api key optional #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irevoire
added
enhancement
irevoire
force-pushed
the
make-the-api-key-optional
branch
from
cdb80a1 to
be7054d
Compare
|
Hey @irevoire Could you fix this ? 🥺 |
irevoire
force-pushed
the
make-the-api-key-optional
branch
from
be7054d to
c263d26
Compare
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Apr 3, 2023
458: make the api key optional r=bidoubiwa a=irevoire
# Pull Request
Since we introduced the `Authentication: Bearer {api_key}` header, sending an empty `api_key` doesn't work anymore, which means it's impossible to use this SDK without an API key.
A lot of noise is due to the doctest update; it's probably easier to review this PR by reading the first commit alone
## Related issue
Fixes #240
## What does this PR do?
- Makes the API key optional when creating a client
## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
Thank you so much for contributing to Meilisearch!
Co-authored-by: Tamo <[email protected]>
|
Build failed: |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Since we introduced the
Authentication: Bearer {api_key}header, sending an emptyapi_keydoesn't work anymore, which means it's impossible to use this SDK without an API key.A lot of noise is due to the doctest update; it's probably easier to review this PR by reading the first commit alone
Related issue
Fixes #240
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!